Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64bit builds & Linux #4

Closed
flihp opened this issue Jun 4, 2018 · 4 comments
Closed

64bit builds & Linux #4

flihp opened this issue Jun 4, 2018 · 4 comments

Comments

@flihp
Copy link
Contributor

flihp commented Jun 4, 2018

I've been working up a few patches to enable use of this code on Linux. Currently I have done enough to get a functional daemon running with test cases from https://github.com/tpm2-software/tpm2-tss.git working as expected. I'm only able to do so when building for a 32bit host though. 64bit builds produce a binary just fine but it hangs when handling commands and I wanted to check to see if 64bit builds are intended to work at all before I spend time debugging this.

My intention is to submit this work as a PR once I've cleaned it up a bit and sorted out this issue with the 64bit builds.

Thanks.

@flihp flihp changed the title Linux build 64bit builds & Linux Jun 4, 2018
@amarochk
Copy link
Contributor

amarochk commented Jun 4, 2018

Hi Philip,

Yes, it would be great if the 64-bit version worked too. But if it going to take significant time, you could commit your 32-bit-only version first.

Thanks,
-Andrey

@flihp
Copy link
Contributor Author

flihp commented Jun 4, 2018

Hey @amarochk. Thanks for the quick response. I just spent a while playing around with the build on Windows and the 32bit build works as expected but I've been unable to get the 64bit build to work. Is this the expected behavior? I'm pretty rusty with windows & VS so it's very likely this is just my own ignorance getting in the way 😄

@amarochk
Copy link
Contributor

amarochk commented Jun 4, 2018

64-bit build works fine as long as you give it the correct (64-bit) OpenSSL binaries (and matching headers). You'll only need to update the '#define RADIX_BITS' definition in Implementation.h (you'll get a compile time error if it does not match the underlying crypto library requirements).

@flihp
Copy link
Contributor Author

flihp commented Jun 6, 2018

Thanks for the hint here @amarochk. This helped a lot in debugging a gap in the RADIX_BITS sanity checks that are done in TPMCmd/tpm/include/ossl/TpmToOsslMath.h. Just put up a PR to fill this gap: #6

@amarochk amarochk closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants