Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Default value of IgnoreStandardErrorWarningFormat inconsistent between product & MSDN #766

Closed
TheRealPiotrP opened this issue Jul 8, 2016 · 5 comments

Comments

@TheRealPiotrP
Copy link
Contributor

TheRealPiotrP commented Jul 8, 2016

According to MSDN, IgnoreStandardErrorWarningFormat should default to true. This shows that it's false. They should be consistent.

@shift-evgeny
Copy link

This isn't just an inconsistency, it's a horrible, horrible hack to fail the build due to some "standard error and warning format" messages. This so-called "standard format" isn't even documented on the linked MSDN page and this is certainly unexpected behaviour for someone creating a pre-build or post-build step in Visual Studio. This hack should certainly be off by default, like the documentation says it is and if someone does want to turn it on, they should have documentation on exactly what strings it looks for.

Looks like I'm not the only one to run into it: http://stackoverflow.com/questions/39466090/why-outputting-error-in-post-build-event-breaks-my-build-in-vs2012

@jeffkl
Copy link
Contributor

jeffkl commented Jan 6, 2017

The property also says it defaults to true: https://github.com/Microsoft/msbuild/blob/56a7b356b96c4d2ddbde7d268990b62a7f3bfca8/src/XMakeTasks/Exec.cs#L106

From what I can tell, it's always been false by default so we'll need to determine what impact there would be, if any, if we change it.

@Sarabeth-Jaffe-Microsoft
Copy link
Contributor

Thanks for the heads up on this. Looking into it now.

Sarabeth-Jaffe-Microsoft added a commit that referenced this issue Feb 23, 2017
IgnoreStandardErrorWarningFormat default is false. 

See: #766
Sarabeth-Jaffe-Microsoft added a commit that referenced this issue Feb 23, 2017
Comment correction. Comment states that _ignoreStandardErrorWarningFormat defaults to true, but it defaults to false. Brought up in discussion #766.
@rainersigwald
Copy link
Member

I don't think this closes the issue. We need the docs site updated, too.

@rainersigwald rainersigwald reopened this Feb 27, 2017
@Sarabeth-Jaffe-Microsoft
Copy link
Contributor

Sarabeth-Jaffe-Microsoft commented Feb 27, 2017

MSDN docs has been updated to correct default value of false.

This exact page hasn't been moved over to docs, so I added a line specifying the default value in docs under "IgnoreStandardErrorWarningFormat": https://docs.microsoft.com/en-us/visualstudio/msbuild/exec-task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants