Remove netcoreap20 #3528
Remove netcoreap20 #3528
Conversation
There was a problem hiding this comment.
LGTM; fyi for SDK/cli folks @livarcocc @nguerrera @dsplaisted
Timing: this will be for MSBuild 16; 15.8 and 15.9 we'll ship from a branch that keeps building this way.
|
Here's me thinking that deleting the tfm will just work. :) |
|
@crummel, does this break any sourcebuild scenarios? |
|
@dotnet-bot test Windows_NT Build for Full |
|
@cdmihai This should be fine for source-build. We should be on at least netcoreapp2.1 for everything consuming MSBuild. I'll try it out but no need to hold it up on our account. |
AndyGerlicher
force-pushed
the
removeNetcoreapp20
branch
from
acf7da7
to
930b1bb
Compare
Remove .NET Core 2.0 results.
* Remove netcoreap20 * Remove .NET Core 2.0 results * Remove netstandard2.0 for Microsoft.Build
* Remove netcoreap20 * Remove .NET Core 2.0 results * Remove netstandard2.0 for Microsoft.Build
|
@AndyGerlicher can you please explain why it was necessary to remove .NET Standard 2.0 targeting (d351690) ? |
|
I don't really remember the details, but I'm pretty sure that Microsoft.Build.dll uses APIs that are not available in all implementations of netstandard2.0. I think we're in agreement here that it is inconvenient, but I don't believe that it can be resolved without breaking changes. |
|
@joeltankam The reason was that it's not generally possible to create working .NET Standard build tasks. There are lots of APIs (System.Reflection.Metadata, System.Collections.Immutable, System.Text.Json) where build tasks that use those APIs need to include the implementations, and the implementations are different for .NET Core and .NET Framework. So compiling an MSBuild task for .NET Standard doesn't help if you need to ship different dependencies for .NET Core and .NET Framework. |
|
@AndyGerlicher @dsplaisted Thank you. |
No description provided.