Add AspNetCore specific properties for csproj intellisense #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkotalik Do you want this for 15.9, or is 16.0 ok? Also, this is the Right Place for this checkin, but we do localization only on the internal copy, so we'll need to dual-check-in to make this actually ship with VS. |
|
Bouncing PR to retest. |
|
15.9 |
|
Can you please rebase onto the |
jkotalik
force-pushed
the
jkotalik/properties
branch
from
e4e0274
to
5ec834e
Compare
|
done. |
shirhatti
reviewed
Sep 20, 2018
| <xs:documentation><!-- _locID_textPackageId _locComment="" -->Indicates whether to run an ASP.NET Core application using IIS in-process or out-of-process.</xs:documentation> | ||
| </xs:annotation> | ||
| </xs:element> | ||
| <xs:element name="AspNetCoreHostingName" type="msb:StringPropertyType" substitutionGroup="msb:Property"> |
|
ping |
AndyGerlicher
approved these changes
Sep 24, 2018
rainersigwald
approved these changes
Sep 24, 2018
|
How should I handle merging this into VS? Should I make a separate PR or is there another process? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AspNetCore is adding a new feature to support inprocess hosting with IIS. We have a few csproj elements that can be specified that we would like to add for intellisense. There doesn't seem to be any extensibility points, so I went ahead and added them to the CommonTypes file.
cc/ @AndyGerlicher @shirhatti