Add Windows Application Package properties to Microsoft.Build.CommonTypes.xsd #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndyGerlicher @rainersigwald could you help to review it? Thanks. |
XianghanWang
changed the title
rainersigwald
requested changes
Jun 14, 2019
There was a problem hiding this comment.
Offline you mentioned that you wanted this for 16.3. Does that mean you do not want it for 16.2? We haven't forked yet, so we don't have a 16.3 branch at the moment. Soon we'll move the remaining 16.2 changes to vs16.2 and make master target 16.3; we can wait until then to merge this. But if it can go into 16.2, we can make that happen too. What is your preference?
rainersigwald
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two properties to fix warnings in DesktopBridge project file.