Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Git LFS? #137

Closed
wjk opened this issue May 18, 2019 · 1 comment
Closed

Use Git LFS? #137

wjk opened this issue May 18, 2019 · 1 comment
Assignees
@wcheng-msft
Labels
Bug Something isn't working

Comments

@wjk
Copy link
Contributor

wjk commented May 18, 2019

Project
MsixCore

Describe the bug
When I tried to push the current master branch to my fork, GitHub warns that there are files (namely, the VLC MSIX files under preview\MsixCore\Tests) that are more than 50MB in size. GitHub recommends that Git LFS be used for files of this size. I don't know if this is practical or not. However, if it can be used, I would appreciate it, as these huge files take forever to download and upload (not to mention what they do to my 1TB Comcast monthly data cap…). Thanks!
@wjk wjk added the Bug Something isn't working label May 18, 2019
@wcheng-msft
Copy link
Contributor

wcheng-msft commented May 29, 2019 •
edited by JohnMcPMS

Thanks for calling this to our attention. I've made the change to use git LFS for the msix and appx files under preview\MsixCore\Tests. ( PR #145 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wcheng-msft wcheng-msft

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wjk @wcheng-msft