Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting the appinstaller file with a new one results in malformed XML #26

Closed
rooju opened this issue Nov 5, 2019 · 2 comments
Closed

Comments

@rooju
Copy link

rooju commented Nov 5, 2019

I had written an appinstaller file by hand and then used this app to generate a new one. In the app, I chose to save the file over the manually created one and that resulted in a malformed appinstaller file.

Here is the original manually authored XML

<?xml version="1.0" encoding="utf-8"?>
<AppInstaller
    xmlns="http://schemas.microsoft.com/appx/appinstaller/2018"
    Version="1.0.0.0"
    Uri="_uriremoved_">
	
    <MainPackage
        Name="FiddlerRepack"
        Publisher="CN=Rooju Chokshi, O=Rooju Corp, S=&quot;Washington C=US&quot;"
        Version="1.0.2.0"
        ProcessorArchitecture="x64"
        Uri="_uriremoved_"/>
		
	<UpdateSettings>
        <OnLaunch HoursBetweenUpdateChecks="12"/>
		<AutomaticBackgroundTask/>
		<ForceUpdateFromAnyVersion>true</ForceUpdateFromAnyVersion>
    </UpdateSettings>
</AppInstaller> 

And after I overwrote using the app this is what it wrote. Note the trailing XML after the first closing AppInstaller tag.

<?xml version="1.0" encoding="utf-8"?>
<AppInstaller
  Version="1.0.2.0"
  Uri="D:\sample msix" xmlns="http://schemas.microsoft.com/appx/appinstaller/2017">
  <MainPackage
    Name="FiddlerRepack"
    Publisher="CN=Rooju Chokshi, O=Rooju Corp, S=&quot;Washington C=US&quot;"
    Version="1.0.2.0"
    ProcessorArchitecture="x64"
    Uri="D:\sample msix\FiddlerRepack_1.0.2.0_x64__4vhfqdnqb7ndr.msix" />
  <UpdateSettings>
    <OnLaunch
      HoursBetweenUpdateChecks="0" />
  </UpdateSettings>
</AppInstaller>unch HoursBetweenUpdateChecks="12"/>
		<AutomaticBackgroundTask/>
		<ForceUpdateFromAnyVersion>true</ForceUpdateFromAnyVersion>
    </UpdateSettings>
</AppInstaller>
@Huios
Copy link
Contributor

Huios commented Nov 6, 2019

Thanks for reporting this issue @rooju . We'll investigate and work on getting a fix out.

Tanaka

@Huios
Copy link
Contributor

Huios commented Mar 3, 2020

@Huios Huios closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants