Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desired Version Negotiation Extension tests #1218

Open
1 of 19 tasks
anrossi opened this issue Feb 9, 2021 · 0 comments
Open
1 of 19 tasks

Desired Version Negotiation Extension tests #1218

anrossi opened this issue Feb 9, 2021 · 0 comments
Labels
Area: Testing Related to test coverage good first issue Good for newcomers
Milestone
Release 2.4

Comments

@anrossi
Copy link
Contributor

anrossi commented Feb 9, 2021 •
edited
Loading

  • Generate invalid Client VNE TP
    • ChosenVersion doesn't match Long Header (Add test for Chosen Version mismatch #3123)
    • ChosenVersion not in OtherVersions list
    • ChosenVersion is zero
    • Zero version in OtherVersions list
    • PreviousVersion = OriginalVersion No longer in spec
    • ReceivedVersions is wrong or empty (on Incompatible VN) No longer in spec
  • Generate invalid Server VNE TP
  • Server "upgrades" client to an incompatible version
  • Known-answer-test for the Client and Server VNE TP
    • Variations on input version to ensure correct compatibility list
  • Refactor QuicVersionNegotiationExtEncodeVersionNegotiationInfo to write an encode/decode test

Copied from #1831

  • Third party tries to force version downgrade via injected VN packet
  • Third party changes the version field during handshake
  • Server initiates incompatible version negotiation, and also does compatible version negotiation on the second attempt.
@anrossi anrossi added the Area: Testing Related to test coverage label Feb 9, 2021
@anrossi anrossi added this to the Future milestone Feb 9, 2021
@nibanks nibanks added the good first issue Good for newcomers label May 11, 2021
@nibanks nibanks mentioned this issue Jul 18, 2021
Closed
3 tasks
@nibanks nibanks modified the milestones: Future, Release 2.2 Aug 9, 2022
@nibanks nibanks modified the milestones: Release 2.2, Release 2.3 Mar 28, 2023
@nibanks nibanks modified the milestones: Release 2.3, Release 2.4 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Testing Related to test coverage good first issue Good for newcomers
Projects
MsQuic Walkthroughs
Status: No status
Milestone
Release 2.4
Development

No branches or pull requests
2 participants
@nibanks @anrossi