Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing commit history due to squash merge from dev to master #129

Closed
sparrowt opened this issue May 5, 2022 · 4 comments
Closed

Confusing commit history due to squash merge from dev to master #129

sparrowt opened this issue May 5, 2022 · 4 comments

Comments

@sparrowt
Copy link
Contributor

sparrowt commented May 5, 2022

As noticed and raised here #86 (comment) I think the master branch has been - perhaps unintentially - deprived of some useful commit history due to #124 being squash merged.

Resulting issues:

  • git blame will be less useful in future on master with changes being attributed to the "Prepare for 1.1.3 release" commit instead of the original commit which references the issue & explains what was being fixed
  • commits appear to be missing from master even though in fact they are on there, e.g. master...dev is far longer than it should be
  • also the reverse diff is non-zero which seems wrong dev...master - dev should have everything that's on master (+ potentially new unrelease stuff) so there shouldn't be code changes on master which show up as being missing from dev

One set of steps to resolve this would be:

  1. force push master to HEAD~1 (i.e. 'undo' c0476cf)
  2. then create a new branch checked out from 1779a24 (where dev was when Prepare for 1.1.3 release #124 was opened)
  3. create a PR from this new branch to master and merge it in a non-squashing way

Any thoughts?

@sparrowt sparrowt changed the title Master branch missing commit history Confusing commit history due to squash merge from dev to master May 5, 2022
@jmah8
Copy link
Contributor

jmah8 commented May 5, 2022

Yes, you are correct about that. We accidentally squash committed. We are planning to fix it during the next release, but we can fix it sooner if you prefer.

@sparrowt
Copy link
Contributor Author

sparrowt commented May 9, 2022

Ah brilliant - I don't mind when as long as it is resolved at some point - thanks!

@jmah8
Copy link
Contributor

jmah8 commented Jun 7, 2022

This is fixed by PR #146. I am going to close this issue, but feel free to reopen it if there are still concerns about the commit history.

@jmah8 jmah8 closed this as completed Jun 7, 2022
@sparrowt
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants