Bulk insert with random column list #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
/azp run CI-MacOS |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run CI-MacOS |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We'll take a look at the PR after we complete our hotfix releases. Thanks for the contribution. |
lilgreenbird
added
the
Enhancement
...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
Show resolved
Hide resolved
...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Show resolved
Hide resolved
…atchExecutionWithBulkCopyTest.java Co-authored-by: Jeffery Wasty <v-jeffwasty@microsoft.com>
tkyc
approved these changes
Mar 3, 2023
Jeffery-Wasty
approved these changes
Mar 6, 2023
lilgreenbird
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
useBulkCopyForBatchInsert=trueconnection parameter leads to invalid batch inserts.Requirements of the problem:
useBulkCopyForBatchInsertconnection parameter value istrueThis PR contains a JUnit test
com.microsoft.sqlserver.jdbc.preparedStatement.BatchExecutionWithBulkCopyTest.testReverseColumnOrder()that can be used to reproduce the problem.
This fix takes the column list order make sure the right values picked for the columns.
Issue: #1993