Faulty DATETIME ticksSinceMidnight overflow check

[Marcono1234]

Driver version

4ff4e7e

Problem description

The Integer.MAX_VALUE < ticksSinceMidnight check here is faulty:

mssql-jdbc/src/main/java/com/microsoft/sqlserver/jdbc/dtv.java

Line 3592 in 4ff4e7e

if (8 != decryptedValue.length || Integer.MAX_VALUE < ticksSinceMidnight) {

ticksSinceMidnight is an int, so it cannot be > Integer.MAX_VALUE. Maybe the solution here is to change ticksSinceMidnight to long (and adjust the calculation from * 10 to * 10L to avoid overflow there).

I am not familiar with this code though and am not planning to submit a pull request.

[tkyc]

Thanks for bringing this up. We'll take a look.