[Feature]: Uncrustify settings enforcing no black line after a conditional

[rogurr]

Feature Overview

A lot of times the code line following a conditional is directly tied to the outcome of the check and it makes sense not to have blank lines inserted.

But if the next line is starting an unrelated task that has it's own comments, not having a blank line to help highlight the comments can make readability harder.

For instance, this code snippet is the original prior to running uncrustify:

 1:  // On error, skip writing the data
 2:  if (!EFI_ERROR (Status)) {
 3:
 4:    // Write depex as a series of hex bytes
 5:    for (x = 0; x < DepexSize; x++) {
 6:      MessageAscii (MsgBuffer, "%02X", Depex[x]);
 7:    }
 8:
 9:    // Free memory provided by the ReadSection call
10:    FreePool (Depex);
11:  }

Running uncrustify removes line 3, pushing the comment directly up under the IF statement making the comment hard to distinguish:

 1:  // On error, skip writing the data
 2:  if (!EFI_ERROR (Status)) {
 4:    // Write depex as a series of hex bytes
 5:    for (x = 0; x < DepexSize; x++) {
 6:      MessageAscii (MsgBuffer, "%02X", Depex[x]);
 7:    }
 8:
 9:    // Free memory provided by the ReadSection call
10:    FreePool (Depex);
11:  }

Solution Overview

Can we have the uncrustify.cfg file updated to remove the enforcement of no blank line after a conditional?

Alternatives Considered

No response

Urgency

Low

Are you going to implement the feature request?

Someone else needs to implement the feature

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

No response

[github-actions]

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[rogurr]

Adding a comment to keep it from being auto-closed.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[github-actions]

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.