Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: False negative on Google Tests death test #394

Closed
1 task done
kuqin12 opened this issue May 6, 2023 · 4 comments
Closed
1 task done

[Bug]: False negative on Google Tests death test #394

kuqin12 opened this issue May 6, 2023 · 4 comments
Assignees
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@kuqin12
Copy link
Contributor

kuqin12 commented May 6, 2023

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

When performing death tests, the outcome is inconsistent and could have false negative results.

A detailed unit test usage is outlined in #393:

One test would fail silently on an access violation, although that due to a unit test bug. To prevent this, one should always populate the matching string. However, such string is not connected to the existing DebugLib.h implementation.

Expected Behavior

A detailed unit test usage is outlined in #393.

But to mitigate the false negative unit tests, we should properly support the asserts for Google Test usage.

Steps To Reproduce

See #393 for full code.

Build Environment

- OS(s): Linux and Windows
- Tool Chain(s): VS2022 and GCC11
- Targets Impacted: x64

Version Information

Top of release/202208

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@kuqin12 kuqin12 added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels May 6, 2023
@github-actions github-actions bot added the urgency:medium Important with a moderate impact label May 6, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Jun 20, 2023
@makubacki
Copy link
Member

  • Write up how asserts should be used in unit tests - just print
  • Get feedback on the proposal

@github-actions github-actions bot removed the state:stale Has not been updated in a long time label Jun 23, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Aug 8, 2023
@github-actions
Copy link

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Development

No branches or pull requests

3 participants