Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support host based unit test on ARM systems #495

Closed
kuqin12 opened this issue Jul 18, 2023 · 9 comments
Closed

[Feature]: Support host based unit test on ARM systems #495

kuqin12 opened this issue Jul 18, 2023 · 9 comments
Assignees
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:feature-request A new feature proposal urgency:medium Important with a moderate impact

Comments

@kuqin12
Copy link
Contributor

kuqin12 commented Jul 18, 2023

Feature Overview

Today's host based unit test is heavily based on x86 architecture. As more targets are for ARM/AARCH64 systems nowadays, there is more need for running host based unit tests on the same architecture as the targets for better test fidelity.

However, the current host based unit test framework mainly builds for x86 systems and would introduce build breaks if we want to compile host based unit tests for AARCH64. i.e. this structure does not exist on ARM systems: https://github.com/microsoft/mu_basecore/blob/3f022dad7ac0035cfe3ed49a12403a7314445383/MdePkg/Test/UnitTest/Include/Library/UnitTestHostBaseLib.h#L88C20-L88C20.

Solution Overview

Plum through the build break when building on host based unit on ARM system and start to deploy the existing host based unit tests to ARM builds (Windows and Linnux).

There might be further tuning for plugins to make the entire flow functional.

Alternatives Considered

No response

Urgency

Medium

Are you going to implement the feature request?

Someone else needs to implement the feature

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@kuqin12 kuqin12 added state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal labels Jul 18, 2023
@github-actions github-actions bot added state:needs-owner Needs an issue owner to be assigned urgency:medium Important with a moderate impact labels Jul 18, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2023
@kuqin12 kuqin12 reopened this Oct 2, 2023
@kuqin12 kuqin12 self-assigned this Oct 2, 2023
@github-actions github-actions bot removed state:needs-owner Needs an issue owner to be assigned state:stale Has not been updated in a long time labels Oct 2, 2023
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Nov 16, 2023
@kuqin12
Copy link
Contributor Author

kuqin12 commented Nov 17, 2023

Took a look at the ARM builds, the cmocka solutions are easily adoptable, with minimal changes (given current usage). See here: https://github.com/kuqin12/mu_basecore/tree/unit_test_arm64

However, the google test pulled in subhook submodule, which is only compatible with x86 systems.. Need to bring up to folks from Google to see if they are interested in supporting this.

@github-actions github-actions bot removed the state:stale Has not been updated in a long time label Nov 17, 2023
Copy link

github-actions bot commented Jan 1, 2024

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Jan 1, 2024
Copy link

github-actions bot commented Jan 9, 2024

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
@kuqin12
Copy link
Contributor Author

kuqin12 commented Jan 9, 2024

We will bring this to EDK2 for broader discussion. Keep this open, please.

@kuqin12 kuqin12 reopened this Jan 9, 2024
@github-actions github-actions bot removed the state:stale Has not been updated in a long time label Jan 10, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Feb 25, 2024
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:feature-request A new feature proposal urgency:medium Important with a moderate impact
Projects
None yet
Development

No branches or pull requests

1 participant