Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSVC] #include "napa.h" cannot surpress warning C4100 #66

Open
fs-eire opened this issue Oct 10, 2017 · 0 comments
Open

[MSVC] #include "napa.h" cannot surpress warning C4100 #66

fs-eire opened this issue Oct 10, 2017 · 0 comments
Labels

Comments

@fs-eire
Copy link
Contributor

fs-eire commented Oct 10, 2017

header file napa/module.h uses #pragma to disable warning C4100 when including v8.h.

napa.h contains napa/module.h, however it fails to disable that warning because v8.h is included before napa/module.h

Current workaround:

#include "napa.h"
// this produces the warning

change to

#include "napa/module.h"
#include "napa.h"
// no warning now.
@fs-eire fs-eire added the bug label Oct 10, 2017
@daiyip daiyip added the P2 label Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants