Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Comments about DSSM better to be cleaned up #93

Closed
jcai2018 opened this issue Feb 5, 2019 · 1 comment
Closed

Comments about DSSM better to be cleaned up #93

jcai2018 opened this issue Feb 5, 2019 · 1 comment
Assignees
@mstfbl
Labels
P1 Needs to be fixed soon.

Comments

@jcai2018
Copy link

jcai2018 commented Feb 5, 2019

DSSM not available in NimbusML but was referenced in comments here: https://github.com/Microsoft/NimbusML/blob/master/src/python/nimbusml/tests/feature_extraction/text/test_wordembedding.py

Better to clean up to avoid confusion. Thanks!
@ganik ganik added the P2 Needs to be fixed at some point. label Aug 22, 2019
@ganik ganik assigned mstfbl and unassigned pieths Nov 25, 2019
@ganik ganik added P1 Needs to be fixed soon. and removed P2 Needs to be fixed at some point. labels Nov 25, 2019
@mstfbl mstfbl mentioned this issue Nov 25, 2019
Merged
@mstfbl
Copy link
Contributor

mstfbl commented Nov 27, 2019

PR #374 fixes this issue. Closing.

@mstfbl mstfbl closed this as completed Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mstfbl mstfbl

Labels
P1 Needs to be fixed soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mstfbl @ganik @jcai2018 @pieths