Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Staging to master to add github metrics #109

Merged
merged 136 commits into from Jul 4, 2019
Merged

Staging to master to add github metrics #109

merged 136 commits into from Jul 4, 2019

Conversation

miguelgfierro
Copy link
Member

Description

In order to start recording the metrics we need to merge the metrics to master.

@irshaffe when this is in master, I need to activate it from devops to be executed every day, it will store the metrics so you can start populating the powerbi dashboard. The original powerbi dashboard for Recommenders was done with Scott (@gramhagen)

Related Issues

#24

Checklist:

  • My code follows the code style of this project, as detailed in our contribution guidelines.
  • I have added tests.
  • I have updated the documentation accordingly.

@miguelgfierro miguelgfierro requested a review from jainr June 19, 2019 17:12
@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/microsoft/nlp/pull/109

You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB.

@gramhagen
Copy link

I was thinking about the github metrics scripts, since they're not related to the content of the repos and only accessible for those with db credentials it might make more sense to have the scripts as artifacts in the devops environment instead of having to check them into each repo. this also allows us to change the metrics scripts without having to push changes to the repo branches.

@miguelgfierro
Copy link
Member Author

I was thinking about the github metrics scripts, since they're not related to the content of the repos and only accessible for those with db credentials it might make more sense to have the scripts as artifacts in the devops environment instead of having to check them into each repo. this also allows us to change the metrics scripts without having to push changes to the repo branches.

two questions: will this artifacts be accessible for the users to see? Some people might want to reuse this metrics for their own repos. Second, if we change this, do you have time to work on this task?

@gramhagen
Copy link

yeah, i have some time over the next few days. I agree it might be interesting for some users, I don't think they will be able to see the artifacts though unless parts of the devops org are public, not sure if that's the plan.

It might be better to keep this in it's own repo, and post it on pypi so it can be installed across all repos without duplicating code? Is this something you think would be feasible / useful?

@miguelgfierro
Copy link
Member Author

@miguelgfierro - shall we merge this, or do you want to make more changes?

sorry I was away, I think we can merge

@miguelgfierro
Copy link
Member Author

It might be better to keep this in it's own repo, and post it on pypi so it can be installed across all repos without duplicating code? Is this something you think would be feasible / useful?

Yeah that makes sense, I'll put it on my backlog

@miguelgfierro
Copy link
Member Author

ok merging this since most of the issues have been solved

@miguelgfierro miguelgfierro merged commit 8968e42 into master Jul 4, 2019
@irshaffe
Copy link
Collaborator

@miguelgfierro has the execution of this script been activated yet? do you have the cosmos db name and credentials that i can use?

@miguelgfierro
Copy link
Member Author

the execution script has been running for a while, but there was a bug that would make it run several times a day (instead of once a day). I added you to an email thread with the bug and will share with you the credentials on teams

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet