Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula (1) in nn_meter/builder/backend_meta/fusion_rule_tester/generate_testcase.py #88

Closed
AIxyz opened this issue Nov 2, 2022 · 1 comment

Comments

@AIxyz
Copy link

AIxyz commented Nov 2, 2022

Hi, @JiahangXu , in nn_meter/builder/backend_meta/fusion_rule_tester/generate_testcase.py, I guess the 'or' should be 'and', because 'or' means $min(T_{op_1}\ ,\ T_{op_2}\ ,\ T_{op_1}+T_{op_2}\ ,\ T_{op_1op_2})$, 'and' means $min(T_{op_1}\ ,\ T_{op_2})$.

secondary_op_lat = min(lat for op, lat in self.latency.items() if op != 'block' or op != self.false_case)

Thanks & Regards,
X. Zhang

@JiahangXu
Copy link
Collaborator

Hi, thanks for raising this issue! Yes, this is a typo and you are right! Thanks for your kind reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants