Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LeakyReLU and Split in ModelSpeedup? #3393

Closed
YuyaKobayashi opened this issue Feb 21, 2021 · 8 comments
Closed

Add support for LeakyReLU and Split in ModelSpeedup? #3393

YuyaKobayashi opened this issue Feb 21, 2021 · 8 comments
Assignees
Milestone

Comments

@YuyaKobayashi
Copy link

YuyaKobayashi commented Feb 21, 2021

What would you like to be added:
Could you add support for LeakyReLU and aten::split in ModelSpeedup.

Why is this needed:
I tried to prune yolov4 but failed with an error RuntimeError: Has not supported infering output shape from input shape for.
I think supporting these node is useful since they are ubiquitous.

Without this feature, how does current nni work
Show error as above.

Components that may involve changes:
ModelSpeedup

Brief description of your proposal if any:

@YuyaKobayashi YuyaKobayashi changed the title Add support for LeakyReLU and Split in Pruning? Add support for LeakyReLU and Split in ModelSpeedup? Feb 21, 2021
@QuanluZhang
Copy link
Contributor

@YuyaKobayashi thanks for reporting your issue. We will support these ops soon. Also we will refactor the implementation to make users easily add the support of new ops. We highly encourage users to contribute new ops :)

@kvartet kvartet added feature request ModelSpeedup user raised help wanted Encourage external contributors to contribute labels Feb 22, 2021
@kvartet kvartet added this to the Backlog milestone Mar 1, 2021
@YuyaKobayashi
Copy link
Author

Thank you

@hxri
Copy link

hxri commented Aug 24, 2021

@YuyaKobayashi thanks for reporting your issue. We will support these ops soon. Also we will refactor the implementation to make users easily add the support of new ops. We highly encourage users to contribute new ops :)

Hi there!

Can I work on this?

@zheng-ningxin
Copy link
Contributor

@hxri
If you are using nn.module's leaky_relu, we have already supported it, but we have not yet supported nn.functional's leaky_relu, you are welcome to contribute code

@scarlett2018
Copy link
Member

@hxri @zheng-ningxin - has this issue been supported in previous releases?

@zheng-ningxin
Copy link
Contributor

#4996
It should work when this PR is merged. Thanks

@Lijiaoa
Copy link
Contributor

Lijiaoa commented Sep 6, 2022

hi, @hxri You could use nni v2.9 to test it. It will be released soon. Please reopen or new an issue if you have any problem.

@scarlett2018
Copy link
Member

hi, @hxri You could use nni v2.9 to test it. It will be released soon. Please reopen or new an issue if you have any problem.

thanks for the follow up, I'm closing as fixed downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants