Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

name of module #9

Closed
joshgav opened this issue Apr 27, 2017 · 4 comments
Closed

name of module #9

joshgav opened this issue Apr 27, 2017 · 4 comments

Comments

@joshgav
Copy link
Contributor

joshgav commented Apr 27, 2017

Can we clarify why we're calling it node-diagnostic-source?

How about node-trace-channel or node-trace-bus 馃殞 ? "bus" is fun in my opinion 馃槅

@SergeyKanzhelev
Copy link

Aligning with the .NET https://github.com/dotnet/corefx/tree/master/src/System.Diagnostics.DiagnosticSource that has exact the same purpose.

@SergeyKanzhelev
Copy link

bus is fun though

@joshgav
Copy link
Contributor Author

joshgav commented Apr 27, 2017

I think it'd be great to choose a name which reflects the functionality clearly - it makes advocating in the community for this that much easier 馃槃 . With that in mind, 'diagnostic' is a long word to say and type, and the meaning of 'source' in this context isn't that clear.

Is there a reason to align with .NET on the name? And why in fact is the .NET module called DiagnosticSource?

Thanks!

@joshgav
Copy link
Contributor Author

joshgav commented May 2, 2017

Conclusion in another thread was to rename the repo to node-diagnostic-channel and the module to diagnostic-channel, see #10. Thanks!

@joshgav joshgav closed this as completed May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants