Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings file missing in npm package #205

Closed
zijpn opened this issue Jun 24, 2018 · 2 comments
Closed

typings file missing in npm package #205

zijpn opened this issue Jun 24, 2018 · 2 comments
Milestone
0.7.6

Comments

@zijpn
Copy link

zijpn commented Jun 24, 2018

Environment details

  • OS: macos
  • OS version: 10.13.5
  • node-pty version: 0.7.5

Issue description

Upgrading from 0.7.4 to 0.7.5 gave me

error TS7016: Could not find a declaration file for module 'node-pty'

I've noticed that the types were moved to a directory called typings.

As the package.json file specifies a files field, I suppose the typings directory needs to be added there as well. (https://docs.npmjs.com/files/package.json#files)
@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2018

Doh, I'll look into it today. Thanks for the quick report!

@Tyriar Tyriar added this to the 0.7.6 milestone Jun 25, 2018
@Tyriar Tyriar closed this as completed in 8fce178 Jun 25, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2018

Should be fixed now with 0.7.6

This was referenced Mar 15, 2020
Open
Open
@snyk-bot snyk-bot mentioned this issue Apr 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.6
Development

No branches or pull requests
2 participants
@Tyriar @zijpn