Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion in conpty.cc Line 110 when exiting VS Code #671

Closed
shanselman opened this issue Mar 6, 2024 · 2 comments · Fixed by #672
Closed

Assertion in conpty.cc Line 110 when exiting VS Code #671

shanselman opened this issue Mar 6, 2024 · 2 comments · Fixed by #672
Assignees
@deepak1556 @rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug windows

Comments

@shanselman
Copy link
Member

Environment details

  • OS: WIndows w
  • OS version: 26058.1400
  • node-pty version: not sure how to check. Feb 28 is the date on the files?

Issue description

When exiting visual studio code on windows I now get a single system bell a quick flash of an error message.

It's so fast I had to do screen recording to capture the single frame!

image

Assertion Failed
File: node-pty\src\win\conpty.cc
Line:110
Expression: status == napi_ok
@shanselman
Copy link
Member Author

@deepak1556 @Tyriar interesting stuff here!

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug windows labels Mar 6, 2024
@deepak1556
Copy link
Contributor

Thanks for the report, I am able to repro the issue.

@deepak1556 deepak1556 mentioned this issue Mar 7, 2024
Merged
@deepak1556 deepak1556 mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepak1556 deepak1556

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: assertion on node environment shutdown microsoft/node-pty
4 participants
@shanselman @deepak1556 @Tyriar @rzhao271