Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailing quote formatted differently on multiple Format calls #45

Closed
mousetraps opened this issue Apr 9, 2015 · 2 comments
Closed

trailing quote formatted differently on multiple Format calls #45

mousetraps opened this issue Apr 9, 2015 · 2 comments

Comments

@mousetraps
Copy link
Contributor

EXPECTED:

var x = foo() ' 

ACTUAL:

var x = foo()'

This will alternate between these two formats as you ctrl+k+d

Test Name: TestInvalidTrailingQuote 
Test FullName: AnalysisTests.FormatterTests.TestInvalidTrailingQuote 
Test Source: e:\DevDiv\Offcycle\xTVS\Open_Source\Nodejs_Main\Nodejs\Tests\AnalysisTests\FormatterTests.cs : line 324 
Test Outcome: Failed 
Test Duration: 0:00:00.0109026 

Result Message: Assert.AreEqual failed. Expected:<var x = foo() '>. Actual:<var x = foo()'>. First and Second call to format had different results... 
Result StackTrace: 
at AnalysisTests.FormatterTests.TestCode(String code, String expected, FormattingOptions options) in e:\DevDiv\Offcycle\xTVS\Open_Source\Nodejs_Main\Nodejs\Tests\AnalysisTests\FormatterTests.cs:line 2043 
at AnalysisTests.FormatterTests.TestInvalidTrailingQuote() in e:\DevDiv\Offcycle\xTVS\Open_Source\Nodejs_Main\Nodejs\Tests\AnalysisTests\FormatterTests.cs:line 325

[copied from codeplex https://nodejstools.codeplex.com/workitem/1877]

@mousetraps mousetraps added the bug label Apr 9, 2015
@mousetraps mousetraps self-assigned this Apr 9, 2015
@ASayre ASayre modified the milestone: April Apr 9, 2015
@mousetraps mousetraps modified the milestones: Future, April Apr 21, 2015
@mousetraps
Copy link
Contributor Author

This is invalid code anyways, so I'm not super inclined to prioritize it. We should investigate if we find it's affecting a more mainline scenario.

@mousetraps mousetraps removed their assignment Jul 26, 2015
@mjbvz
Copy link
Contributor

mjbvz commented Apr 4, 2016

This test (TestInvalidTrailingQuote) seems to be passing and I can't repo this behavior on NTVS Alpha 1.2, with either Full Intellisense or ES6 preview Intellisense.

Please reopen if I interpreted this bug incorrectly.

@mjbvz mjbvz closed this as completed Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants