Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page produces debugging output #47

Closed
techxplorer opened this issue Jun 10, 2015 · 2 comments
Closed

Settings page produces debugging output #47

techxplorer opened this issue Jun 10, 2015 · 2 comments

Comments

@techxplorer
Copy link

Hi,

The local/o365/settings.php file can produce debugging output due to the way that it requires the jQuery library.

For example:

$PAGE->requires->jquery();

Should really be:

if (!$PAGE->requires->is_head_done()) {
    $PAGE->requires->jquery();
}

This ensures that the jQuery library is only included / loaded when it is safe to do so.

Steps to replicate:

  1. Login is admin
  2. Access a users profile
  3. Login as that user
  4. See the debugging output displayed
@jamesmcq
Copy link
Contributor

Thanks techxplorer! I'll include that in the next release. (or feel free to submit a pull request if you want the commit).

@jamesmcq
Copy link
Contributor

jamesmcq commented Aug 5, 2015

This is now in stable, thanks!

@jamesmcq jamesmcq closed this as completed Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants