Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address mypy errors #27

Closed
underchemist opened this issue Sep 23, 2021 · 0 comments
Closed

Address mypy errors #27

underchemist opened this issue Sep 23, 2021 · 0 comments
Assignees

Comments

@underchemist
Copy link
Contributor

underchemist commented Sep 23, 2021

Related to #5 and #26, which introduces mypy as a pre-commit hook with configuration defined in pyproject.toml. Currently this is set to ignore all errors but disabling this option and running mypy -p oaff or pre-commit run --all-files results in a large number of errors. See here for an example mypy output.

This issue is meant to track work required to resolve errors produced by mypy.

A question I'm not sure the answer to:
Is ignore_missing_imports=true appropriate here? even with mypy --install-types there are multiple packages without type stubs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants