Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to support older browsers #124

Merged
merged 1 commit into from Oct 7, 2022
Merged

Small fixes to support older browsers #124

merged 1 commit into from Oct 7, 2022

Conversation

pkaya89
Copy link
Contributor

@pkaya89 pkaya89 commented Sep 26, 2022 •
edited

2 Changes to support older browsers:

  1. Deep clone message object before calling postMessage to prevent errors
  2. Fixed missing import for BroadcastChannel (this was undefined in older versions of safari supported from v. 15.4)

@pkaya89 pkaya89 marked this pull request as ready for review September 26, 2022 15:40
@pkaya89 pkaya89 requested a review from a team as a code owner September 26, 2022 15:40
@pkaya89
Copy link
Contributor Author

pkaya89 commented Sep 27, 2022

@charliewang95 @xTEddie
Hi, I'm a first time contributor, the CLA check is still showing as queued even though I agreed - there seems to be no way to rerun this check is this normal?

@sarojkpr
Copy link
Contributor

sarojkpr commented Oct 7, 2022 •
edited

Thankyou for your contribution to the open source.

Will you be able to complete this PR quickly? We need the BroadcastChannel change. Let me know if anything blocks you, I'll create a separate with your changes

@pkaya89
Copy link
Contributor Author

pkaya89 commented Oct 7, 2022

@microsoft-github-policy-service agree

@pkaya89
Copy link
Contributor Author

pkaya89 commented Oct 7, 2022 •
edited

No unresolved conversations
There aren't yet any conversations on this pull request.

@sarojkpr I think it's good to merge now thank you

@sarojkpr sarojkpr merged commit 99bac9c into microsoft:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarojkpr sarojkpr sarojkpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkaya89 @sarojkpr