This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Support custom domain names used as OneFuzz endpoints in deployment #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2720 +/- ##
=======================================
Coverage 28.75% 28.75%
=======================================
Files 320 320
Lines 38191 38191
=======================================
Hits 10980 10980
Misses 27211 27211 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 task
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds support for custom domain names used as OneFuzz endpoints through an optional argument to deploy.py for
--custom_domain. Using this argument will include the custom domain passed in the Allowed token audiences setting of the Azure Function App authentication settings.Fixes #2695