Fix yolo demo for iOS and macOS Safari #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@fs-eire Hello, could you review this PR if you have time? |
|
@fs-eire Thank you for the review! If it's OK, please merge it because I have no permission to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the great demo!
I found a bug that Yolo demo doesn't detect any objects with a camera on iOS devices (Safari and Chrome) and macOS Safari.
It seemed drawImage doesn't work because an invalid area was specified.
I fixed it and also adjust the layout.
I deployed the fixed version to my website here.
Could you check this PR?