You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems these tests rely on the caller to specify the opset version, which somehow gets derived from the file path.
The ONNX models already specify the opset version they're using. That should be respected.
It looks like this opset16 is not really useful. This function iterates through all opsets in model folder.
publicstaticIEnumerable<object[]>GetModelsForTest(){varmodelsDir= GetTestModelsDir();varmodelsDirInfo=new DirectoryInfo(modelsDir);varskipModels= GetSkippedModels(modelsDirInfo);foreach(var opsetDir in modelsDirInfo.EnumerateDirectories()){//var modelRoot = new DirectoryInfo(Path.Combine(modelsDir, opsetDir.Name));foreach(var modelDir in opsetDir.EnumerateDirectories()){if(!skipModels.ContainsKey(modelDir.Name)){yieldreturnnewobject[]{ modelDir.Parent.Name, modelDir.Name };}}//model}//opset}
This function is used to generate inputs for
[Theory(DisplayName ="TestPreTrainedModels")][MemberData(nameof(GetModelsForTest))][MemberData(nameof(GetSkippedModelForTest), Skip ="Skipped due to Error, please fix the error and enable the test")]privatevoidTestPreTrainedModels(stringopset,stringmodelName)
It seems these tests rely on the caller to specify the opset version, which somehow gets derived from the file path.
The ONNX models already specify the opset version they're using. That should be respected.
onnxruntime/csharp/test/Microsoft.ML.OnnxRuntime.Tests.NetCoreApp/InferenceTest.netcore.cs
Line 441 in 466b2d9
onnxruntime/csharp/test/Microsoft.ML.OnnxRuntime.EndToEndTests/runtest.sh
Line 22 in 466b2d9
The text was updated successfully, but these errors were encountered: