Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnnxRuntime C# library - add support for Sequence and Map model output types #156

Closed
jignparm opened this issue Dec 12, 2018 · 6 comments
Closed
Labels
feature request request for unsupported feature or enhancement

Comments

@jignparm
Copy link
Contributor

Add support in C# OnnxRuntime Library for sequences and maps (complex types). Tensors are the only supported type currently.

@snnn
Copy link
Member

snnn commented Dec 12, 2018

That requires the C API supports complex types, which should be a huge work. Because sequences and maps are not the only non-tensor types. Instead of doing them one by one, we should have a clear roadmap first.

@jignparm
Copy link
Contributor Author

There's a model that a user converted to Onnx (see dotnet/machinelearning#1323), which produces a Sequence<Map<int,float>> as an output. It seems like a valid ONNX model, and therefore should able to run inference on it. Is there a non C API which is running this inference currently?

@snnn
Copy link
Member

snnn commented Dec 14, 2018

The python binding is using the C++ API, but C# is using the C API, because it is not possible to access C++ functions through P/Invoke.

@faxu faxu added the feature request request for unsupported feature or enhancement label Feb 4, 2019
@derdanielb
Copy link

Any progress to this? @jignparm

Loading a model which outputs Sequence<Map<int,float>> does not work using the latest C# onnxruntime nuget package (v 0.2.1).
However loading the model using python onnxruntime works fine.

I could really use an implementation of this in the C# onnxruntime.

@jignparm
Copy link
Contributor Author

This functionality is in progress (i.e. the C API supports it now), and surfacing it in C# is in progress. Should be available next week.

@jignparm
Copy link
Contributor Author

jignparm commented Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request for unsupported feature or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants