Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MacOS] Unable to load libonnxruntime.dylib because binaries are not signed. #16168

Open
osobeso opened this issue May 30, 2023 · 3 comments
Open
Labels
build build issues; typically submitted using template

Comments

@osobeso
Copy link

osobeso commented May 30, 2023

Describe the issue

We're having trouble running one of our extensions from IntelliCode on MacOSX.
After debugging the process, it seems like our process is throwing an exception when it tries to load libonnxruntime.dylib because it seems the binaries are not properly signed (It complains about missing Team Name on the signing).
I've downloaded the binaries from the Nuget Package, and the artifacts output from this repo, and ran a codesign -v libonnxruntime.dylib on the binaries and I'm getting result of 'code object is not signed at all'.

I'm wondering if this is an issue on our end, or if in fact the MacOS binaries you are distributing are not signed.

I would really appreciate some guidance on this, as we need to determine whether we should be doing our own signing, even though it's a third party library.

Thanks!

To reproduce

Download any version of OnnxRuntime compatible with MacOSx and try to run it or do a codesign -v to verify it's signature.

Urgency

This is blocking an upcoming release, and we want to just make sure we're not doing anything wrong before we try to sign it ourselves.

Platform

Mac

OS Version

12.6.6

ONNX Runtime Installation

Released Package

ONNX Runtime Version or Commit ID

latest

ONNX Runtime API

C#

Architecture

X64

Execution Provider

Other / Unknown

Execution Provider Library Version

No response

@snnn snnn added the build build issues; typically submitted using template label May 31, 2023
@snnn
Copy link
Member

snnn commented May 31, 2023

@mszhanyi, could you please help? If you have any questions, please create an email thread. Here is not a good place to talk about the details of signing.

@snnn snnn closed this as completed May 31, 2023
@snnn
Copy link
Member

snnn commented Jun 17, 2023

Fixed in ONNX Runtime 1.15.1 release.

@chen-rn
Copy link

chen-rn commented Oct 19, 2023

It seems that the 1.16 versions are not signed once again
Screenshot 2023-10-19 at 9 51 46 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build issues; typically submitted using template
Projects
None yet
Development

No branches or pull requests

3 participants