Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up WriteAsV2 for Server / Document / SecurityScheme / SecurityRequirement #49

Closed
PerthCharern opened this issue Oct 31, 2017 · 0 comments · Fixed by #52
Closed

Clean up WriteAsV2 for Server / Document / SecurityScheme / SecurityRequirement #49

PerthCharern opened this issue Oct 31, 2017 · 0 comments · Fixed by #52
Assignees
@PerthCharern

Comments

@PerthCharern
Copy link
Contributor

No description provided.

@PerthCharern PerthCharern self-assigned this Oct 31, 2017
PerthCharern added a commit that referenced this issue Nov 1, 2017
@PerthCharern
Fixes #49
210b333 
Fix logic for WriteAsVX for these objects:
- Document (still not complete)
- Server
- OAuthFlow
- SecurityScheme
- SecurityRequirement

Add Unit tests for
- Server
- SecurityScheme
- SecurityRequirement

Also, resolves #19. I am using FluentAssertions in the unit test now. The main reason is that I want a richer error message that tells us where the two strings are different. The built-in Assert from xUnit is not as good. This should help us write unit test faster.

Future tests can use FluentAssertions, and we can revise old test on an incremental basis.

If you strongly object FluentAssertions, we should discuss before we make more investments on this.
@PerthCharern PerthCharern mentioned this issue Nov 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PerthCharern PerthCharern

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@PerthCharern