Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with .Net Standard 2.0 #12

Closed
colinthompson opened this issue Nov 14, 2017 · 4 comments
Closed

Incompatibility with .Net Standard 2.0 #12

colinthompson opened this issue Nov 14, 2017 · 4 comments

Comments

@colinthompson
Copy link

When trying to add this package to a project targeting .NET standard 2.0, an error is thrown because OpenScraping v1.0.1 only supports netcoreapp2.0.

Here is the output when running dotnet add OpenScraping:

info :   GET https://api.nuget.org/v3-flatcontainer/openscraping/index.json
info :   OK https://api.nuget.org/v3-flatcontainer/openscraping/index.json 380ms
error: Package OpenScraping 1.0.1 is not compatible with netstandard2.0 (.NETStandard,Version=v2.0). Package OpenScraping 1.0.1 supports: netcoreapp2.0 (.NETCoreApp,Version=v2.0)
error: Package 'OpenScraping' is incompatible with 'all' frameworks in project '<REDACTED>/Project.csproj'.
@zmarty
Copy link
Contributor

zmarty commented Nov 16, 2017

I am still navigating the differences between them, but as you noticed the library currently supports .Net Core, not .Net Standard.

@willadsen
Copy link

@colinthompson I've create a PR, #15 which hopefully will be merged soon

@colinthompson
Copy link
Author

Thanks! Looking forward to it.

@zmarty
Copy link
Contributor

zmarty commented Aug 23, 2018

Thank you Andreas, this is now in master.

@zmarty zmarty closed this as completed Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants