Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

redundant configuration will make user confused when they configure their cluster-configuration #154

Closed
ydye opened this issue Jan 2, 2018 · 2 comments
Assignees

Comments

@ydye
Copy link
Contributor

ydye commented Jan 2, 2018

https://github.com/Microsoft/pai/blob/4fe556bf6714230dde79e2eaa819226e34f58edd/service-deployment/clusterconfig-example.yaml#L104

I don't think each module need configure this IP address. Actually we could get this information through the code following.

{%- for host in cluster_config if 'prometheus' in cluster_config[ host ] -%}
    {{cluster_config[ host ]['ip']}}{% if not loop.last %},{% endif %}
{%- endfor -%}

And many place should remove the redundant configuration too.

@fanyangCS
Copy link
Contributor

a part of deployment refinement efforts

@ydye
Copy link
Contributor Author

ydye commented Jul 15, 2018

I think this issue could be closed. Because we have refactored our configuration. And now, it's much easier then that time. @fanyangCS @scarlett2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants