Cannot build 7.2.5 with master

[pepone]

I getting this errors trying to build php-7.2.5 branch

 Creating library D:\php-sdk\php-7.2-nts-release\vc15\x86\php-src\Release\php_zip.lib and object D:\php-sdk\php-7.2-nts-release\vc15\x86\php-src\Release\php_zip.exp
php_zip.obj : error LNK2019: unresolved external symbol __imp__zip_add referenced in function _get_module
php_zip.obj : error LNK2019: unresolved external symbol __imp__zip_add_dir referenced in function _get_module
php_zip.obj : error LNK2019: unresolved external symbol __imp__zip_get_file_comment referenced in function _get_module
php_zip.obj : error LNK2019: unresolved external symbol __imp__zip_get_num_files referenced in function _zif_zip_open
php_zip.obj : error LNK2019: unresolved external symbol __imp__zip_rename referenced in function _get_module

[weltling]

Thanks for the report. What is the configure line? Which dependencies do you use?

Apart from that, only tags should be used, except you want to dev something on the SDK.

Thanks.

[pepone]

I using 7.2 dependencies

Configuration: 7.2-vc15-x86-stable

Processing package ICU-61.1-vc15-x86.zip
Processing package apache-2.4.28-vc15-x86.zip
Processing package c-client-2007f-vc15-x86.zip
Processing package fbclient-3.0-nocrt-x86.zip
Processing package freetype-2.8.1-vc15-x86.zip
Processing package glib-2.53.3-vc15-x86.zip
Processing package libargon2-20171227-vc15-x86.zip
Processing package libbzip2-1.0.6-vc15-x86.zip
Processing package libcurl-7.59.0-vc15-x86.zip
Processing package libenchant-1.6.0-vc15-x86.zip
Processing package libffi-3.2.1-vc15-x86.zip
Processing package libiconv-1.15-1-vc15-x86.zip
Processing package libintl-0.18.3-1-vc15-x86.zip
Processing package libjpeg-9b-vc15-x86.zip
Processing package liblmdb-0.9.21-vc15-x86.zip
Processing package libpng-1.6.34-vc15-x86.zip
Processing package libpq-9.6.5-vc15-x86.zip
Processing package libqdbm-1.8.78-vc15-x86.zip
Processing package libsasl-2.1.27-1-vc15-x86.zip
Processing package libssh2-1.8.0-vc15-x86.zip
Processing package libtidy-5.4.0-vc15-x86.zip
Processing package libwebp-0.6.1-vc15-x86.zip
Processing package libxml2-2.9.7-vc15-x86.zip
Processing package libxpm-3.5.12-1-vc15-x86.zip
Processing package libxslt-1.1.32-vc15-x86.zip
Processing package libzip-1.4.0-v15-x86.zip
Processing package mpir-3.0.0-vc15-x86.zip
Processing package net-snmp-5.7.3-vc15-x86.zip
Processing package nghttp2-1.29.0-vc15-x86.zip
Processing package openldap-2.4.45-vc15-x86.zip
Processing package openssl-1.1.0h-vc15-x86.zip
Processing package wineditline-2.205-vc15-x86.zip
Processing package zlib-1.2.11-vc15-x86.zip
Processing package libsodium-1.0.16-vc15-x86.zip
Updates performed successfully. 

configure:

--enable-cli --enable-cgi --with-all-shared --disable-zts --with-prefix=D:\php-7.2-x86-nts-release

Enabled extensions:
-----------------------
| Extension  | Mode   |
-----------------------
| bcmath     | shared |
| calendar   | shared |
| com_dotnet | shared |
| ctype      | shared |
| date       | static |
| dom        | shared |
| filter     | static |
| gd         | shared |
| hash       | shared |
| iconv      | static |
| json       | static |
| libxml     | static |
| mysqlnd    | static |
| opcache    | shared |
| pcre       | static |
| phar       | static |
| readline   | shared |
| reflection | static |
| session    | static |
| simplexml  | shared |
| spl        | static |
| standard   | static |
| tokenizer  | shared |
| wddx       | shared |
| xml        | shared |
| xmlreader  | shared |
| xmlwriter  | shared |
| zip        | shared |
| zlib       | static |
-----------------------


Enabled SAPI:
-------------
| Sapi Name |
-------------
| cgi       |
| cli       |
-------------


----------------------------------------------
|                 |                          |
----------------------------------------------
| Build type      | Release                  |
| Thread Safety   | No                       |
| Compiler        | MSVC15 (Visual C++ 2017) |
| Architecture    | x86                      |
| Optimization    | PGO disabled             |
| Static analyzer | disabled                 |
----------------------------------------------

[weltling]

Thanks for the further info. It's not a SDK issue, but the config issue in PHP. The current dependency package has only a static libzip build. A temporary solution on your side is to compile ext/zip static. Or alternatively, apply php/php-src@afc3f6e.

Thanks.

[pepone]

Thanks for the info