Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileHandler doesnt handle errors argument #98

Closed
pamelafox opened this issue Sep 25, 2022 · 0 comments · Fixed by #161
Closed

FileHandler doesnt handle errors argument #98

pamelafox opened this issue Sep 25, 2022 · 0 comments · Fixed by #161
Labels
cpython-incompatibility Relates to an incompatibility with stdlib logging help wanted Extra attention is needed

Comments

@pamelafox
Copy link
Member

https://docs.python.org/3/library/logging.handlers.html#logging.FileHandler

In CPython, the errors argument is saved on the instance and passed to the file open command. Picologging does pass errors to the FileHandler constructor but then does nothing with it. Is this an intentional difference? Seems like it'd be a relatively straightforward PR.
@tonybaloney tonybaloney added the cpython-incompatibility Relates to an incompatibility with stdlib logging label Sep 26, 2022
@tonybaloney tonybaloney added the help wanted Extra attention is needed label Oct 10, 2022
@aminalaee aminalaee mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cpython-incompatibility Relates to an incompatibility with stdlib logging help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add FileHandler errors argument aminalaee/picologging
2 participants
@pamelafox @tonybaloney