-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Provide ability to pass CancellationToken into Async methods #1652
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Yea, it would be nice. |
I think that for most cases it would be more than enough to pass the |
Closing it, since there are no plans to support it. Browser interactions like clicks, fills are all not cancelable, so even if we would provide it, it would be a kinda fake cancel, and a certain action would still run in the background. |
@mxschmitt this is true from a browser user perspective, but I think it's really not about cancelling any actions/commands but more about cancelling potential waiting process for the callbacks of the commands. As far as I can see all commands are sent via I would really appreciate, if you would reconsider your decision or give us some alternative way to gracefully cancel pending commands. |
Is there a way to use cancellation tokens to cancel async operations?
It would be helpful to have most of the async methods able to be cancelled. Especially methods like
await page.GotoAsync("https://github.com/");
which would then be:
await page.GotoAsync("https://github.com/", cancellationToken);
The text was updated successfully, but these errors were encountered: