Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright Java - is there a way to use system node version ? #1016

Closed
mEklavya opened this issue Jul 28, 2022 · 16 comments
Closed

Playwright Java - is there a way to use system node version ? #1016

mEklavya opened this issue Jul 28, 2022 · 16 comments
Labels

Comments

@mEklavya
Copy link

Playwright.create() is failing as it is installing the node.exe in the temp directory which the user is not allowed to run. Is there a way not to use this temp path and use system node js installed in program files

image

@yury-s
Copy link
Member

yury-s commented Jul 28, 2022

No, the node.js and the driver files is essential part of Playwright. You can configure alternative location of the temp directory by providing playwright.driver.tmpdir java system property (see #728 for more details). Would that work for you?

@yury-s yury-s transferred this issue from microsoft/playwright Jul 28, 2022
@mEklavya
Copy link
Author

Thanks, team for the quick response.
No, it will not work. As in our organization, you can not run the .exe file until is whitelisted and digitally verified. Also, Node Js is available in Program files and the same needs to be used.

Is there any other way?

@yury-s
Copy link
Member

yury-s commented Jul 29, 2022

We don't support running with a system node version as of today. There is a java property that is used for development purposes only, you can point that one to a preinstalled driver but you need to understand what you are doing as it has to be updated along with playwright etc. The property is playwright.cli.dir.

@yury-s
Copy link
Member

yury-s commented Aug 1, 2022

What we can easily do is to allow providing a path to preinstalled Node.js in an environment variable or as Playwright constructor parameter. We'd still have to extract the node modules into a temp directory and run them from there. Would this approach address your issue or extracting even node js modules (all javascript, no native code as of today) to a temp directory would still be a problem?

@mEklavya
Copy link
Author

Thanks, it will be good to have environment variables for it, if the user doesn't pass then it takes default.
Can the temp directory path be controlled using environment variables?

@yury-s
Copy link
Member

yury-s commented Aug 11, 2022

Can the temp directory path be controlled using environment variables?

Only with a java system property today but we can add an environment variable too. Is there a reason why the java property doesn't work for you?

@yury-s
Copy link
Member

yury-s commented Aug 16, 2022

Now that the PR has landed you can specify custom node location with PLAYWRIGHT_NODEJS_PATH env variable or playwright.nodejs.path java system property. You can give it a try in Playwright v1.26.0-SNAPSHOT

@mEklavya
Copy link
Author

Thank you @yury-s , will wait for updated version:)

One more query, in the current version, how can we know from where node and other dependencies are getting downloaded?

@yury-s
Copy link
Member

yury-s commented Aug 25, 2022

The driver is extracted from driver-bundle maven package, on the first run it will download browsers from CDN.

@mEklavya
Copy link
Author

mEklavya commented Aug 29, 2022

The driver is extracted from driver-bundle maven package, on the first run it will download browsers from CDN.

Thanks a lot, Yuri driver Bundle was clear, but what about other temp files in the Playwright-Java-xxxxxxx folder like Node.exe, playwright.cmd etc, from where it gets downloaded at the first run?

@yury-s
Copy link
Member

yury-s commented Aug 29, 2022

Everything in the temp directory is extracted from the same module. Does it break somewhere in your environment?

@mEklavya
Copy link
Author

mEklavya commented Sep 2, 2022

Everything in the temp directory is extracted from the same module. Does it break somewhere in your environment?

Yes, we see that printdeps.exe is not signed which is getting extracted from this module, and also not able to understand its usage. Can you please help us by signing it? As it is unsigned it is not allowed to run in corporate.

Also how often we will be updating our node.exe and other files which are getting downloaded in temp dir? Let's say if there is a version change in the node version then we will be adapting it.

@yury-s
Copy link
Member

yury-s commented Sep 2, 2022

Yes, we see that printdeps.exe is not signed which is getting extracted from this module, and also not able to understand its usage. Can you please help us by signing it? As it is unsigned it is not allowed to run in corporate.

We can definitely sign it, it's an oversight on our end. The source code of the program is here, it hasn't changed for a while and the binary we use is here. We use it to check that all browser dependency libraries are present on the host system and if they are not we will print out missing ones.

Also how often we will be updating our node.exe and other files which are getting downloaded in temp dir? Let's say if there is a version change in the node version then we will be adapting it.

The node is baked into the driver-bundle package so it's only updated when that package is updated. If you install node separately it's up to you when to update it.

@mEklavya
Copy link
Author

mEklavya commented Sep 6, 2022

Yes, we see that printdeps.exe is not signed which is getting extracted from this module, and also not able to understand its usage. Can you please help us by signing it? As it is unsigned it is not allowed to run in corporate.

We can definitely sign it, it's an oversight on our end. The source code of the program is here, it hasn't changed for a while and the binary we use is here. We use it to check that all browser dependency libraries are present on the host system and if they are not we will print out missing ones.

Thank you, will it be also available with the next version?

@mxschmitt

This comment was marked as resolved.

@mxschmitt
Copy link
Member

I filed an upstream feature request for it to sign the Windows binaries: microsoft/playwright#17165

We unfortunately can't provide an eta for it, depending on the demand we'll work on it.

Since the original issue is fixed (make it possible to use a custom Node.js version) I'll close this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants