New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwright Java - is there a way to use system node version ? #1016
Comments
No, the node.js and the driver files is essential part of Playwright. You can configure alternative location of the temp directory by providing |
Thanks, team for the quick response. Is there any other way? |
We don't support running with a system node version as of today. There is a java property that is used for development purposes only, you can point that one to a preinstalled driver but you need to understand what you are doing as it has to be updated along with playwright etc. The property is playwright.cli.dir. |
What we can easily do is to allow providing a path to preinstalled Node.js in an environment variable or as Playwright constructor parameter. We'd still have to extract the node modules into a temp directory and run them from there. Would this approach address your issue or extracting even node js modules (all javascript, no native code as of today) to a temp directory would still be a problem? |
Thanks, it will be good to have environment variables for it, if the user doesn't pass then it takes default. |
Only with a java system property today but we can add an environment variable too. Is there a reason why the java property doesn't work for you? |
Now that the PR has landed you can specify custom node location with |
Thank you @yury-s , will wait for updated version:) One more query, in the current version, how can we know from where node and other dependencies are getting downloaded? |
The driver is extracted from driver-bundle maven package, on the first run it will download browsers from CDN. |
Thanks a lot, Yuri driver Bundle was clear, but what about other temp files in the Playwright-Java-xxxxxxx folder like Node.exe, playwright.cmd etc, from where it gets downloaded at the first run? |
Everything in the temp directory is extracted from the same module. Does it break somewhere in your environment? |
Yes, we see that printdeps.exe is not signed which is getting extracted from this module, and also not able to understand its usage. Can you please help us by signing it? As it is unsigned it is not allowed to run in corporate. Also how often we will be updating our node.exe and other files which are getting downloaded in temp dir? Let's say if there is a version change in the node version then we will be adapting it. |
We can definitely sign it, it's an oversight on our end. The source code of the program is here, it hasn't changed for a while and the binary we use is here. We use it to check that all browser dependency libraries are present on the host system and if they are not we will print out missing ones.
The node is baked into the driver-bundle package so it's only updated when that package is updated. If you install node separately it's up to you when to update it. |
Thank you, will it be also available with the next version? |
This comment was marked as resolved.
This comment was marked as resolved.
I filed an upstream feature request for it to sign the Windows binaries: microsoft/playwright#17165 We unfortunately can't provide an eta for it, depending on the demand we'll work on it. Since the original issue is fixed (make it possible to use a custom Node.js version) I'll close this one for now. |
Playwright.create() is failing as it is installing the node.exe in the temp directory which the user is not allowed to run. Is there a way not to use this temp path and use system node js installed in program files
The text was updated successfully, but these errors were encountered: