Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Playwright Manylinux Compliance #688

Closed
kumaraditya303 opened this issue May 13, 2021 · 3 comments
Closed

[BUG] Playwright Manylinux Compliance #688

kumaraditya303 opened this issue May 13, 2021 · 3 comments

Comments

@kumaraditya303
Copy link
Contributor

The wheels of playwright on PyPI https://pypi.org/project/playwright/1.10.0/#files have manylinux compliance of
manylinux1 and hence should be usable on distros newer centos5 as per the policy of the manylinux project but playwright only supports Ubuntu 18.04 & Ubuntu 20.04 https://playwright.dev/docs/intro?_highlight=syste#system-requirements hence playwright should restrict installation of the wheels to the only supported platforms and operating system. With PEP 600 playwright can restrict installation to glibc version 2.17 or higher which would restrict its installation to only supported platforms. Also playwright driver requires glibc 2.17 or higher hence older versions wont't event get error as the driver cannot able to dlopen shared libs.

@pavelfeldman
Copy link
Member

The wheels of playwright on PyPI https://pypi.org/project/playwright/1.10.0/#files have manylinux compliance of
manylinux1 and hence should be usable on distros newer centos5 as per the policy of the manylinux project

We only support Ubuntu 18 and Ubuntu 20 officially, there is a sections in the docs for this: https://playwright.dev/python/docs/next/intro#linux. We don't expect users to install Playwright on the unsupported systems.

We tried restricting the installation with your patch, but that broke customers that were on the supported Ubuntu 18 system. We prioritize experience of the customers that are on the supported systems, so the patch was reverted.

Overall, even if we restrict the installation, Centos users won't feel better - what they really want is for Playwright to work. With that, I am closing this issue.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented May 13, 2021

We tried restricting the installation with your patch, but that broke customers that were on the supported Ubuntu 18 system. We prioritize experience of the customers that are on the supported systems, so the patch was reverted.

It didn't broke because of my patch, it broke because the official docker image for ubuntu 18 mcr.microsoft.com/playwright:bionic uses an outdated pip of version 9 which was released in 2016 https://pypi.org/project/pip/9.0.1/

@pavelfeldman

@kumaraditya303
Copy link
Contributor Author

@pavelfeldman What centos version are you talking about ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants