Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION] npm install playwright@0.12.0 #1513

Closed
jperl opened this issue Mar 24, 2020 · 3 comments
Closed

[REGRESSION] npm install playwright@0.12.0 #1513

jperl opened this issue Mar 24, 2020 · 3 comments

Comments

@jperl
Copy link
Contributor

jperl commented Mar 24, 2020

Context:

  • Playwright Version: 0.12.0
  • Operating System: Mac
  • Last working version: 0.11.1-next.1584997668668 (current next)

Code Snippet

See the npm install step: https://github.com/qawolf/playwright-video/runs/531356245

Checkout qawolf/playwright-video@71d7d37 and run npm install

Describe the bug

(node:2762) UnhandledPromiseRejectionWarning: TypeError: downloadOptionsFromEnv is not a function
    at /home/runner/work/playwright-video/playwright-video/node_modules/playwright/install.js:21:40
    at Object.<anonymous> (/home/runner/work/playwright-video/playwright-video/node_modules/playwright/install.js:24:3)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
(node:2762) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
@jperl jperl changed the title [BUG] [BUG] npm install playwright@0.12.0 Mar 24, 2020
@mxschmitt
Copy link
Member

I can also reproduce this behaviour:

➜  backend git:(renovate/all-minor-patch) ✗ npm install playwright-core@0.12.0 playwright@0.12.0

> playwright@0.12.0 install /Users/max.schmitt/Development/try-playwright/backend/node_modules/playwright
> node install.js

(node:4819) UnhandledPromiseRejectionWarning: TypeError: downloadOptionsFromEnv is not a function
    at /Users/max.schmitt/Development/try-playwright/backend/node_modules/playwright/install.js:21:40
    at Object.<anonymous> (/Users/max.schmitt/Development/try-playwright/backend/node_modules/playwright/install.js:24:3)
    at Module._compile (internal/modules/cjs/loader.js:971:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1011:10)
    at Module.load (internal/modules/cjs/loader.js:822:32)
    at Function.Module._load (internal/modules/cjs/loader.js:730:14)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1051:12)
    at internal/main/run_main_module.js:16:11
(node:4819) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:4819) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
+ playwright@0.12.0
+ playwright-core@0.12.0
updated 2 packages and audited 1204719 packages in 11.879s
found 1503 low severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details

@jperl jperl changed the title [BUG] npm install playwright@0.12.0 [REGRESSION] npm install playwright@0.12.0 Mar 24, 2020
@mxschmitt
Copy link
Member

Will be fixed in #1514

@jperl
Copy link
Contributor Author

jperl commented Mar 24, 2020

I can confirm this is fixed in 0.12.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants