Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Potential performance regression in 'chrome-beta' channel #15715

Closed
unlikelyzero opened this issue Jul 15, 2022 · 4 comments
Closed

[BUG] Potential performance regression in 'chrome-beta' channel #15715

unlikelyzero opened this issue Jul 15, 2022 · 4 comments

Comments

@unlikelyzero
Copy link
Contributor

Context:

  • Playwright Version: 1.23.0
  • Operating System: official playwright container - focal
  • Node.js version: 16 lts
  • Browser: Chrome Beta Channel. Specifically version '104.0.5112.39'

Code Snippet

The code is addressed by our PR here nasa/openmct#5500

To run,

git clone https://github.com/nasa/openmct.git
Add a .only to `test('Can use the reset button to reset the image'` in `./e2e/tests/plugin/imagery/exampleImagery`
nvm use 16
npm install
npx playwright install
npm run test:e2e -- --project=chrome-beta

Essentially we have 2 tests which are either slowed or skipped when running against the 'chrome-beta' channel. We specifically added chrome-beta to our support matrix after this regression hit nasa/openmct#5184

Describe the bug

Slow and unreliable behavior specifically in chrome-beta

@yury-s
Copy link
Member

yury-s commented Jul 15, 2022

I followed the steps you described but I'm getting the following error:

1) e2e/tests/plugins/imagery/exampleImagery.e2e.spec.js:184:10 › Example Imagery Object › Can use the reset button to reset the image 

    page.goto: Protocol error (Page.navigate): Cannot navigate to invalid URL
    =========================== logs ===========================
    navigating to "/", waiting until "networkidle"
    ============================================================

      37 |     test.beforeEach(async ({ page }) => {
      38 |         //Go to baseURL
    > 39 |         await page.goto('/', { waitUntil: 'networkidle' });

Any idea what could be wrong?

Would it be possible to extract the failing test in a standalone test?

@ozyx
Copy link

ozyx commented Jul 15, 2022

@yury-s

Sorry, you will also need to specify the config file:

headless:
npm run test:e2e -- --config=e2e/playwright-ci --project=chrome-beta

or

headed:
npm run test:e2e -- --config=e2e/playwright-local --project=chrome-beta

@yury-s
Copy link
Member

yury-s commented Jul 16, 2022

I tried running the following two commands both on a linux box and in a docker container:

npm run test:e2e -- --config=e2e/playwright-ci.config.js --project=chrome-beta
npm run test:e2e -- --config=e2e/playwright-ci.config.js --project=chrome

The numbers are about the same: 6-7s spent in the test and about 30s on the overall run inlcuding startup of the server etc.

Both OS's had Chrome beta 104.0.5112.48-1.

Essentially we have 2 tests which are either slowed or skipped when running against the 'chrome-beta' channel.

Can you share your numbers? Also what do you mean by test is "skipped" ?

@dgozman
Copy link
Contributor

dgozman commented Jul 21, 2022

@unlikelyzero It seems like we cannot reproduce this issue. If you have more information that would help us fix the issue, please open a new one and link to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants