Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow expect.soft to create a screenshot for each fail #17664

Closed
marko-simic opened this issue Sep 28, 2022 · 2 comments
Closed

[Feature] Allow expect.soft to create a screenshot for each fail #17664

marko-simic opened this issue Sep 28, 2022 · 2 comments

Comments

@marko-simic
Copy link

It would be great for us to have created, and to the report attached, a screenshot for each failed soft assertation.

@pavelfeldman
Copy link
Member

Why was this issue closed?

Thank you for your involvement. This issue was closed due to limited engagement (upvotes/activity), lack of recent activity, and insufficient actionability. To maintain a manageable database, we prioritize issues based on these factors.

If you disagree with this closure, please open a new issue and reference this one. More support or clarity on its necessity may prompt a review. Your understanding and cooperation are appreciated.

@dandoris33
Copy link

I'm wondering if this would be handy for a screen shot, why not all the info necessary to see what was happening at the time? Sure could see one assert "Just use the trace viewer and be done with it...." Might be a fair assertion while it might be nice to have what would be effectively bookmarks to easily go to the point an except.soft() failed... One other thought might be to have a global setting to allow even hard errors from expect to not end the test? Completely different issue but my point i think would still be valid? Back to the idea for the book mark, when opening the trace viewer, say i have 'x' soft errors, would be nice to click on a link and have it take me to that error?

Sorry for the slow input, only stumbled on this in the PW discord. No problem opening a new issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants