Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add ability to change testInfo?.project._expect?.timeout parameter in method currentExpectTimeout() for custom test runner #18634

Closed
abay-ibrayev opened this issue Nov 8, 2022 · 3 comments

Comments

@abay-ibrayev
Copy link

We are using mocha-based runner. And we started to use expect from @playwright/test lib.

Main Issue: We are not able to change default timeout from 5000ms to 30000ms.

Feature request: Could u please provide ability to change not only from PlaywrightTestConfig?

PlaywrightTestConfig - works only with pw test runner (so provide expect.timeout here not working for us)

@yury-s
Copy link
Member

yury-s commented Nov 8, 2022

expect from @playwright/test is supposed to be used only within Playwright Test runner. Making it a standalone library is not a goal for playwright and we have no plans changing that.

Is there a reason you cannot use playwright test runner?

@yury-s yury-s added the triaging label Nov 8, 2022
@abay-ibrayev
Copy link
Author

ok, got it, it's sad but thanks anyway. Unfortunately, our test framework have a lot of dependencies from mocha runner across all project, so it's a big task for us switching to pw test runner :c

@topolanekmartin
Copy link

I am struggling with same problem right now. I am using cucumber-js with playwright and I need increase except timeout. But I can't because cucumber-js ignore playwright.config.ts file. Can somebody tell me if there is some workarround please?

I don't want to write function which rewrite file packages/playwright/src/common/globals.ts in node_modules directory in order to increase timeout 🙈 But I don't see any other solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants