Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Absorb @sand4rt/playwright-ct-web #20076

Open
sand4rt opened this issue Jan 12, 2023 · 7 comments
Open

[Feature] Absorb @sand4rt/playwright-ct-web #20076

sand4rt opened this issue Jan 12, 2023 · 7 comments

Comments

@sand4rt
Copy link
Collaborator

sand4rt commented Jan 12, 2023

Created a lib for lit/web components. Would be awesome if it could be absorbed by Playwright sooner or later:
https://github.com/sand4rt/playwright-ct-web

related to: #14241

@pavelfeldman
Copy link
Member

I'm somewhat hesitant doing until we settle the larger frameworks and call it stable. Otherwise, every time we refactor thing we need to move a lot of code. It goes exponential. Wdyt?

@sand4rt
Copy link
Collaborator Author

sand4rt commented Jan 14, 2023

It is definitely tedious from a maintenance point of view. There is already quite a bit of duplicate code and tests. I think would be good to improve that. Perhaps with the suggestions made in #14516 ? Or perhaps with a shared (playwright-ct-core) library which could make the code in the @playwright-ct-{framework} packages more DRY? This would also allows easier usage for lesser-known frameworks which will not be absorbed. Anyway, i think this problem can be solved somehow and IMO don't see it as a reason to wait till stable.

Besides Angular, i consider native web components to be one of the bigger ones and i don't think there's a good testing solution for it ATM. In addition, i think that a breadth-first rather than depth-first approach to adding ct libraries and features increases the likelihood of a better and a more consistent API.

@siggerzz
Copy link

Would love to see this! We're going to be using Lit heavily in our design system, and it would be great to not rely on tools like Storybook for our tests! 🙏🏼

@jamieomaguire
Copy link

Fully agree with @siggerzz, this would be supremely useful if Playwright could offer web component support! Our design system is making extensive use of the lib @sand4rt has created

@sand4rt
Copy link
Collaborator Author

sand4rt commented Jul 30, 2023

@pavelfeldman Is it an option to relocate it to the Playwright community ORG?

@jamieomaguire
Copy link

@pavelfeldman is there any update on this? :)

@siggerzz
Copy link

@pavelfeldman Just wondering if there's potential to get any movement on this? Lit continues to grow in popularity, and as a maintainer of a growing Web Component library that heavily relies on Playwright for testing, it would be great if there was official support similar to React / Vue.

Our component test coverage would not be possible without the work done by @sand4rt, however, it's an on-going risk for users of Lit using a library with a sole maintainer.

If there's anything I can do to help move this along, it'd be much appreciated.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants