-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] ignoreHTTPSErrors ignored in Webkit on MacOS #22495
Comments
I can repro and see the following in the output:
This looks like an error happening in the proxy itself that WebKit then shows as "SSL error". Since Unfortunately, digging further is complicated and most likely ends up out of scope of Playwright project. I'd recommend to inspect the actual network traffic sent from the browser to the proxy and double check that everything is as expected. Let me know what you think. |
Does Webkit use any kind of public key or certificate pinning on MacOS? |
@dgozman Do you understand why the |
@divdavem on Mac, WebKit uses MacOS network stack that is closed source, so we don't have much insights into it. I assume that Safari would exhibit the same behavior; could you please check if this is the case? |
It doesn't look like we can help here much, so I'll have to close this for now. Feel free to file a new issue if you think we can be helpful to you! |
System info
The problem was also happening on Windows (with WebKit) with version 1.31.0 of Playwright. This seems to have been fixed in the latest version of Playwright.
Here is another issue similar to this one: [BUG] ignoreHTTPSErrors flag is being ignored when using WebKit on Linux through https proxy #9466
Source code
Link to the GitHub repository with the repro
https://github.com/divdavem/kassette-playground
Steps
Clone repository:
git clone https://github.com/divdavem/kassette-playground cd kassette-playground
Install dependencies
Run tests with proxy
The proxy used in this scenario is kassette. It plays the role of a man-in-the-middle, it provides a certificate generated on the fly that is not signed by a recognized certificate authority. However, as the test uses
ignoreHTTPSErrors
, this https error should be ignored.Expected
Tests succeed in all browsers on all platforms.
Actual
Tests only fail with Webkit on MacOS, cf the logs on GitHub CI
In the trace viewer, it is possible to see the following message:
An SSL error has occurred and a secure connection to the server cannot be made
.The text was updated successfully, but these errors were encountered: