Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Custom matcher marks as passed but custom matcher inner assertion is failed #30501

Closed
Nck1969 opened this issue Apr 24, 2024 · 1 comment

Comments

@Nck1969
Copy link

Nck1969 commented Apr 24, 2024

Version

1.43.1 (latest)

Steps to reproduce

I add simple example in sandbox

Fork this example and run tests via "yarn playwright test"

In our project it looks like:
image
One step fails but tests marks as passsed:
image

Expected behavior

I expected to see that the custom matcher failed

Actual behavior

All is passed

Additional context

No response

Environment

System:
    OS: macOS 14.4.1
    Memory: 2.94 GB / 64.00 GB
  Binaries:
    Node: 20.10.0 - /usr/local/bin/node
    Yarn: 4.1.1 - /opt/homebrew/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
  Languages:
    Bash: 3.2.57 - /bin/bash
@pavelfeldman
Copy link
Member

Move pass = true; down a couple of lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants