Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] pass arguments like proxy to each context not to whole browser #4321

Closed
Shinoby92 opened this issue Nov 3, 2020 · 4 comments
Closed

Comments

@Shinoby92
Copy link

Shinoby92 commented Nov 3, 2020

Like the title say's
creating one browser and one context results that only the browser can get a proxy value, so testing different proxys needs to create multiple browsers. Better it would be that these arguments can get passed to the context , so adding each proxy to the context having 1 browser with multiple contexts each of them their own proxy ( I guess there are more arguments that would be benefit generally to having the arguments passed to the context if wished)

@mxschmitt
Copy link
Member

Hi, there was already an issue for it #3534 which got implemented in the tip-of-tree (master) version. You can try it out directly and don't have to wait for a release if you want. Otherwise it gets released in the upcoming weeks.

@Shinoby92
Copy link
Author

thanks I just found it now in the master tree, but im using playwright python and I can't install the master tree with pip because I get the failure that the package misses /site-packages/playwright/driver/playwright-cli

so I guess I have to wait for the next version push and release that I can install it normally via pip install for python right :x?

@yifeikong
Copy link

Is this feature available in python? I still got errors like:

playwright._impl._api_types.Error: Browser needs to be launched with the global proxy.

@mxschmitt
Copy link
Member

Yes, which Playwright Python version are you using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants