Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] codegen: use name to reference iframes #5174

Closed
arjunattam opened this issue Nov 10, 2020 · 0 comments · Fixed by #5175
Closed

[Feature] codegen: use name to reference iframes #5174

arjunattam opened this issue Nov 10, 2020 · 0 comments · Fixed by #5175
Labels
P3-collecting-feedback

Comments

@arjunattam
Copy link
Contributor

Codegen should prefer name attribute on iframes instead of the url.
@dgozman dgozman transferred this issue from microsoft/playwright-cli Jan 27, 2021
@dgozman dgozman changed the title [Codegen] Use name to reference iframes [Feature] codegen: use name to reference iframes Jan 27, 2021
This was referenced Jan 27, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3-collecting-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codegen): prefer frame name over url when unique
2 participants
@arjunattam @dgozman