Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] codegen: race when element changes the selector during the action #5186

Closed
dgozman opened this issue Dec 3, 2020 · 0 comments
Closed

[BUG] codegen: race when element changes the selector during the action #5186

dgozman opened this issue Dec 3, 2020 · 0 comments
Assignees
@dgozman

Comments

@dgozman
Copy link
Contributor

dgozman commented Dec 3, 2020

We should make our actions timeout after ~1s, and catch the timeout exception from the binding to undo the "waiting for action result" bit.
@dgozman dgozman transferred this issue from microsoft/playwright-cli Jan 27, 2021
@dgozman dgozman changed the title codegen: race when element changes the selector during the action [BUG] codegen: race when element changes the selector during the action Jan 27, 2021
@dgozman dgozman self-assigned this Jan 27, 2021
@dgozman dgozman added the P2-bug label Jan 27, 2021
@dgozman dgozman mentioned this issue Jan 27, 2021
Merged
@dgozman dgozman closed this as completed Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgozman