Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration script from puppeteer #563

Closed
KevinGrandon opened this issue Jan 22, 2020 · 5 comments
Closed

Migration script from puppeteer #563

KevinGrandon opened this issue Jan 22, 2020 · 5 comments

Comments

@KevinGrandon
Copy link

Nice library you all have here, it's unfortunate that this is not a new major version of puppeteer though. I think you all would gain a lot more adoption if you had a script to convert puppeteer tests to playwright tests. There should be a way of automatically doing this with a codemod.

@JoelEinbinder
Copy link
Contributor

The apis are very similar. It should mostly be replacing require(“puppeteer”) with playwright. Is something particularly painful to transition?

@giuseppeg
Copy link

Would you have time to make a codemod?

@joewood
Copy link

joewood commented Jan 24, 2020

Out of interest, any reason why the new features couldn't have been added to Puppeteer with a feature flag? Is there a more fundamental re-architecture in PlayWright?

@pavelfeldman
Copy link
Member

pavelfeldman commented Feb 19, 2020

Playwright is cross-browser and Puppeteer was only done for Chrome. Not all the Puppeteer APIs and abstractions made sense for cross-browser story. Playwright aims at testing: we wait for elements to be interactable when we click, etc. That's a significant change in philosophy, so maintaining the API would be misleading.

I don't think we will be providing a conversion utility, but there already are migration guides available in the wild: https://medium.com/@davert/puppeteer-to-playwright-migration-guide-6c86ea66e85e

@mmbatha
Copy link

mmbatha commented Nov 3, 2022

Playwright is cross-browser and Puppeteer was only done for Chrome. Not all the Puppeteer APIs and abstractions made sense for cross-browser story. Playwright aims at testing: we wait for elements to be interactable when we click, etc. That's a significant change in philosophy, so maintaining the API would be misleading.

I don't think we will be providing a conversion utility, but there already are migration guides available in the wild: https://medium.com/@davert/puppeteer-to-playwright-migration-guide-6c86ea66e85e

The author deleted the Medium article referred to above

sand4rt pushed a commit to sand4rt/playwright that referenced this issue Dec 21, 2022
* chore: auto update stars button count

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants